Trevor Turk
JZ -- I started in on this yesterday but go caught up in Resque work. There's a lot of activity with a new maintainer, so I want to ride the wave. I'll get back to this tomorrow -- sorry about the delay.
Jason Zimdars
No rush at all. This is work I'm trying to fit into my other stuff.
Trevor Turk
So, I looked at the way BCX was implemented and it seemed like there was some additional complexity because of Stacker, so I went with the bare minimum skeleton for a start. I'm sure we'll have to add/change some stuff (I didn't bother with a "force standard view" feature just yet, for example) but maybe this is enough to get you going?
Trevor Turk
I think you should be good to go, but holler if there's anything else you'd like me to help with. I started off with a login page and a main landing page for the links. I could wire those up with minimal styling if you like, etc...
Trevor Turk completed the to-do
Jason Zimdars
This is on my back-burner now, I'll get back to you when I'm able to jump-in.
Looking over the branch it looks great. I'm going to try to go with no-JS on this so I think we can even remove the sprockets include.
Thanks!
Jason Zimdars
TT! I've got a bunch of this designed and working right now. I'd like to do some simple JS starting with the mini-framework we're using on BCX mobile. Would it be possible for you to add Coffeescript support to Launchpad?
Your implementation is great so far. I've only run into one real bug: when I try to make a sign-out link it doesn't work (my guess is it's looking for a phone format and failing). I'm still on the fence about having one at all, but for now it won't work.
The only other thing I could maybe use some help with is this:
I'm not sure how to make one, but it seems like we should probably make a proper collection of just the bcx's rather than the way I did it.
Nothing urgent here, but if you have some spare time I'd love another assist on this.
Jason Zimdars
TT, I'm having trouble with something else here. Jeff noticed some exceptions from the identity#edit action. The trick with this one is that we don't actually have a phone version of this template and we don't intend to have one right now.
How can we force ignore the phone format here where non exists?
I tried using respond_to but that still returned a 500 error. Maybe there is something in the implementation ignoring that?
Jason Zimdars
Ok, I think I have this one nipped. TT, your suggestion to set the request format was right-on. The only difference is it needed to be set in a before_filter.
After attempting to replicate the issue it appears that this actually is limited to BCX. The other apps all have plugin implementations for the identity#edit template. Only BCX shoves you off to LP. It turns out the way people are getting this error is when they're on a mobile device but have forced the full view. The edit identity link is visible, but their still on a phone format device.
Discuss this to-do
JZ -- I started in on this yesterday but go caught up in Resque work. There's a lot of activity with a new maintainer, so I want to ride the wave. I'll get back to this tomorrow -- sorry about the delay.
No rush at all. This is work I'm trying to fit into my other stuff.
So, I looked at the way BCX was implemented and it seemed like there was some additional complexity because of Stacker, so I went with the bare minimum skeleton for a start. I'm sure we'll have to add/change some stuff (I didn't bother with a "force standard view" feature just yet, for example) but maybe this is enough to get you going?
https://github.com/37signals/launchpad/compare/mobile
I think you should be good to go, but holler if there's anything else you'd like me to help with. I started off with a login page and a main landing page for the links. I could wire those up with minimal styling if you like, etc...
Trevor Turk completed the to-do
This is on my back-burner now, I'll get back to you when I'm able to jump-in.
Looking over the branch it looks great. I'm going to try to go with no-JS on this so I think we can even remove the sprockets include.
Thanks!
TT! I've got a bunch of this designed and working right now. I'd like to do some simple JS starting with the mini-framework we're using on BCX mobile. Would it be possible for you to add Coffeescript support to Launchpad?
Your implementation is great so far. I've only run into one real bug: when I try to make a sign-out link it doesn't work (my guess is it's looking for a phone format and failing). I'm still on the fence about having one at all, but for now it won't work.
The only other thing I could maybe use some help with is this:
https://github.com/37signals/launchpad/blob/4d95c4813cdbc01d44afef3c07630a12df8cdf47/app/views/phone/identities/show.phone.erb#L8-31
I'm not sure how to make one, but it seems like we should probably make a proper collection of just the bcx's rather than the way I did it.
Nothing urgent here, but if you have some spare time I'd love another assist on this.
TT, I'm having trouble with something else here. Jeff noticed some exceptions from the identity#edit action. The trick with this one is that we don't actually have a phone version of this template and we don't intend to have one right now.
How can we force ignore the phone format here where non exists?
I tried using respond_to but that still returned a 500 error. Maybe there is something in the implementation ignoring that?
format.html { render :layout => 'edit' }Any ideas for how to handle this?
Ok, I think I have this one nipped. TT, your suggestion to set the request format was right-on. The only difference is it needed to be set in a before_filter.
After attempting to replicate the issue it appears that this actually is limited to BCX. The other apps all have plugin implementations for the identity#edit template. Only BCX shoves you off to LP. It turns out the way people are getting this error is when they're on a mobile device but have forced the full view. The edit identity link is visible, but their still on a phone format device.
Deployed and seems to be working. THanks!
Ah ah. Nice catch!